This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
chore(expectedConditions): update generic Function typings #5101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnishina
force-pushed
the
upgrade_jasmine
branch
5 times, most recently
from
9ea9bb4
to
63ca713
Compare
|
That worked! There was a bug in the test suite when setting the EC to a const. Since it is a global var it can be changed to a different instance. This is because the EC is tied to the browser, browsers are tied to the session. If you restart the browser or fork the browser, the const EC points to an old session. I am not sure how this passed in previous tests. We must have made a change recently. |
cnishina
commented
Dec 19, 2018
cnishina
force-pushed
the
upgrade_jasmine
branch
from
63ca713
to
0cf1d4c
Compare
|
Backed out Jasmine 3.3 changes for ExpectedConditions and other tsc errors. |
cnishina
force-pushed
the
upgrade_jasmine
branch
2 times, most recently
from
7530446
to
de72230
Compare
cnishina
changed the title
cnishina
force-pushed
the
upgrade_jasmine
branch
from
de72230
to
b2ceb36
Compare
heathkit
suggested changes
Dec 20, 2018
cnishina
force-pushed
the
upgrade_jasmine
branch
from
b2ceb36
to
0aceb42
Compare
- Use `() => Promise<boolean>` over `Function` typings. - Fix an ExpectedConditions test where it was set to a const. - Fix a TypeScript typing interface issue with RunResults in taskRunner.
cnishina
force-pushed
the
upgrade_jasmine
branch
from
0aceb42
to
cee662a
Compare
heathkit
approved these changes
Dec 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
() => Promise<boolean>overFunctiontypings.